feat(scope): dont use hub for capturing events anymore#2132
Merged
Conversation
Litarnus
force-pushed
the
core-state-swap
branch
from
June 24, 2026 11:14
186fbd0 to
b9bdf63
Compare
Litarnus
force-pushed
the
capture-on-scope
branch
from
June 24, 2026 11:14
3645777 to
105cd55
Compare
stayallive
approved these changes
Jul 6, 2026
Comment on lines
+13
to
+14
| use Sentry\State\BreadcrumbRecorder; | ||
| use Sentry\State\EventCapturer; |
Collaborator
There was a problem hiding this comment.
Capturer is awkward in my head maybe EventRecorder is a nice fit. But highly subjective so feel free to leave as is!
Contributor
Author
There was a problem hiding this comment.
Yeah that makes more sense, we have BreadcrumbRecorder and SpanRecorder so that would fit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts logic into
BreadcrumbRecorderandEventCatcherand replaces usage infunctions.phpto no longer use theHub.